Whole review makes me think if we should create some kind of (community wiki?) master questions for design patterns like "homemade rollup summary", "fetch keys to helper set before querying for related records" etc and then upvote / link to them a lot. My point is that while the topic has been beaten to death on lots of blogs - people keep posting such questions... Similar with most commonly hit error messages?
As @AlexTennant I tend to be quite... critical in code reviews ;)
Needs improvement - 4
Got a question about improving code coverage - very situation-specific, poor reusability, tagged visualforce unit-test - wat? Not Google'able at all, not accepted by the original asker (although there's a thank you comment)...
Show/hide pageBlockSection - OP came back to the question, made a comment instead of answer, one of answers misspells rerender
, the code in question - that's not how you should write Visualforce... And lots of cruft that isn't related to the "core" problem.
Another non-bulk trigger question, this time quite massive one. Too much code in the sample, "while deploying" in the title doesn't really help (or maybe it does, maybe that trigger is so old the unit tests for it come from before seeAllData
times). The answers are good & helpful but very generic help can be given here I think and it's again one that has poor reusability...
Account.name question - looks like interesting question that somehow didn't attract enough attention. One answer kind of helps but treats it as black magic that you just need to learn (at least that's how I feel about it). I misses key piece of information about full describe results vs. object & field tokens. The other answer in my opinion is completely off the mark - how info about System.debug
helps here?
Satisfactory - 4
Q about bulkifying a fairly simple trigger. Typos in the very first sentence, luckily has some good answers - both the "further reading" as well as walkthrough how to apply the tips to this particular instance.
Question about Contacts being the users of a mobile app - not sure what to do with this one really. Answer is great considering the vague question, couldn't get it to show up in Google results though (saturation with S1-related hype + "recent" rename of portals into communities?)
List has no rows to for assignment to sobject - fairly clear question (after edits), pretty good answer (as I said, I love it when the answer list general rule + practical application for this specific situation). Still makes me think we could build a highly upvoted community wiki answer for that error?
Q about formulas syntax - it's OK. Hard to Google. Good help given to this particular post (including spotting the typos in field names) but I'd say too little for real reuse, especially compared with official formula samples for example.
Excellent - 2
How to support drag&drop with full calendar on ipad - Finally something that does pop up on 1st page in Google search. Fairly clear question, definitely enlightened answer. Could use some code samples (intellectual property problems I think) but I'd say we need more of these.
What's the difference between these authentication endpoints? - great question, great answers, good position in Google, 'nuff said.