Skip to main content
Commonmark migration
Source Link

Might've gotten a bit ahead of myself on my previous meta.

It'd be helpful to have some guidelines to determine if a given question is or is not a code-review question.

The intent here is to start with a broad definition, and then comments/answers can refine it. Hopefully, we'll end up with a clear winner in terms of votes.

So, to start things off...

##What makes a question a request for a code-review?

What makes a question a request for a code-review?

  • It contains code that is currently working (if not the most ideal/following best practices)
  • The "problem statement" of the question primarily revolves around improving the code rather than overcoming an error, learning specifics about a piece of functionality, getting code to work in the first place, that kind of thing
  • Instead of focusing on fixing a single thing, there are likely to be multiple components where improvements can be made or best practices can be followed

I think that this question fits the criteria for being a code-review question
I think that this other question does not fit the criteria for being a code-review

Might've gotten a bit ahead of myself on my previous meta.

It'd be helpful to have some guidelines to determine if a given question is or is not a code-review question.

The intent here is to start with a broad definition, and then comments/answers can refine it. Hopefully, we'll end up with a clear winner in terms of votes.

So, to start things off...

##What makes a question a request for a code-review?

  • It contains code that is currently working (if not the most ideal/following best practices)
  • The "problem statement" of the question primarily revolves around improving the code rather than overcoming an error, learning specifics about a piece of functionality, getting code to work in the first place, that kind of thing
  • Instead of focusing on fixing a single thing, there are likely to be multiple components where improvements can be made or best practices can be followed

I think that this question fits the criteria for being a code-review question
I think that this other question does not fit the criteria for being a code-review

Might've gotten a bit ahead of myself on my previous meta.

It'd be helpful to have some guidelines to determine if a given question is or is not a code-review question.

The intent here is to start with a broad definition, and then comments/answers can refine it. Hopefully, we'll end up with a clear winner in terms of votes.

So, to start things off...

What makes a question a request for a code-review?

  • It contains code that is currently working (if not the most ideal/following best practices)
  • The "problem statement" of the question primarily revolves around improving the code rather than overcoming an error, learning specifics about a piece of functionality, getting code to work in the first place, that kind of thing
  • Instead of focusing on fixing a single thing, there are likely to be multiple components where improvements can be made or best practices can be followed

I think that this question fits the criteria for being a code-review question
I think that this other question does not fit the criteria for being a code-review

Source Link
Derek F
  • 64.1k
  • 14
  • 20

What do we count as being a "code review" question?

Might've gotten a bit ahead of myself on my previous meta.

It'd be helpful to have some guidelines to determine if a given question is or is not a code-review question.

The intent here is to start with a broad definition, and then comments/answers can refine it. Hopefully, we'll end up with a clear winner in terms of votes.

So, to start things off...

##What makes a question a request for a code-review?

  • It contains code that is currently working (if not the most ideal/following best practices)
  • The "problem statement" of the question primarily revolves around improving the code rather than overcoming an error, learning specifics about a piece of functionality, getting code to work in the first place, that kind of thing
  • Instead of focusing on fixing a single thing, there are likely to be multiple components where improvements can be made or best practices can be followed

I think that this question fits the criteria for being a code-review question
I think that this other question does not fit the criteria for being a code-review